fix: use fee asset for dust amount conversion - Githubissues

shapeshift / web

ShapeShift Web

https://app.shapeshift.com

MIT License

172 stars 185 forks source link

fix: use fee asset for dust amount conversion #8168

Closed kaladinlight closed 21 hours ago

kaladinlight commented 22 hours ago

Description

Use feeAsset to convert dust amount to ensure the correct amount of dust sent for savers withdrawal transactions.

Issue (if applicable)

https://discord.com/channels/554694662431178782/886041582422356018/1309237779984551997

Risk

High Risk PRs Require 2 approvals

Low - savers withdrawals should succeed again (usdc/usdt)

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Ensure you can withdraw usdc and usdt positions on ethereum
Ensure the correct dust amount fee is displayed to the user

Engineering

:point_up:

Operations

[ ] :checkered_flag: My feature is behind a flag and doesn't require operations testing (yet)

:point_up:

Screenshots (if applicable)

https://etherscan.io/tx/0x3b9976d9770edd28de241588cfb0f1af258b5c9c8fcb284261664fcc187ea56b https://viewblock.io/thorchain/tx/3b9976d9770edd28de241588cfb0f1af258b5c9c8fcb284261664fcc187ea56b https://indexer.thorchain.shapeshift.com/v2/actions?txid=3b9976d9770edd28de241588cfb0f1af258b5c9c8fcb284261664fcc187ea56b

kaladinlight commented 20 hours ago

@woodenfurniture oof, should have moved to draft maybe. I have not confirmed a working tx yet. I saw your jam was for lp as opposed to savers withdraw. I am going to back this out until confirmed officially.