search

shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
173 stars 190 forks source link

protocol fee on portals is way overstated #8266

Closed 0xean closed 1 hour ago

0xean commented 6 hours ago

Screenshot 2024-12-04 at 5 12 40 PM

repro steps:

  1. get a portals quote
  2. click into the trade confirm page
  3. notice the large protocol fee
gomesalexandre commented 6 hours ago

We may either have to rethink that assumption, or are dealing with wrong precision here

https://github.com/shapeshift/web/blob/2f7cfc1318f29fa140aca1b97f7ef4f983b54d24/packages/swapper/src/swappers/PortalsSwapper/getPortalsTradeQuote/getPortalsTradeQuote.ts#L180-L188