search

shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
157 stars 180 forks source link

Allow use of app without connected wallet/"demo mode" #895

Closed 0xdef1cafe closed 2 years ago

0xdef1cafe commented 2 years ago

Overview

Many users have requested to be able to use the app (app.shapeshift.com) without first connecting a wallet. This makes sense from an engagement perspective - people want to see what things look and feel like before they use it.

Reference

Guidance

At a high level, the app should be as functional as possible, without the user being able to get into a broken state.

Acceptance criteria

Bounty Hunters

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 5750.0084 FOX (2097.06 USD @ $0.36/FOX) attached to it as part of the ShapeShift fund.

amitojsingh366 commented 2 years ago

Could I attempt this bounty, I feel like I will be able to achieve the desired result here

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 264 years, 9 months from now. Please review their action plans below:

1) amitojsingh366 has been approved to start work.

I would love to work on this bounty, I already have a lot of experience with this code base 2) thevastmajority has applied to start work _(Funders only: approve worker | reject worker)_.

Use the useWallet hook to detect the presence (or rather, lack thereof) of a wallet for logic Add a grey button to the splash screen below the Connect Wallet, saying "Try without a wallet..." Redirect to FOX asset page as the first screen instead of /dashboard Disable send/receive buttons on asset pages Hide account page link in nav Hide accounts from asset pages Hide balance chart buttons, make sure pages default to price charts Disconnect wallet button should disconnect wallet and clear portfolio, but not boot the user back out to the connect-wallet screen Trade dialog Sell assets should be fetched from all assets list, not users portfolio assets Confirm trade button should be disabled Defi vaults - show modal but stop the user at step 1 3) dhruvjain1122 has applied to start work _(Funders only: approve worker | reject worker)_.

I am interested in this project, and will complete this project with testing. I haven't done any shapeshift project till now so, it would be a good start for me to become a part of your ecosystem 4) stackedq has applied to start work _(Funders only: approve worker | reject worker)_.

I have deep experience in react (+6 years), I also have seen the repo previously.

I'm going to:

Estimated time: 3 days 5) soptq has applied to start work _(Funders only: approve worker | reject worker)_.

The guidance is clear for implementation.

Estimated Time: Less than a week.

Learn more on the Gitcoin Issue Details page.

dmosc commented 2 years ago

In case the bounty assignee spot opens again, can I give it a try?

amitojsingh366 commented 2 years ago

In case the bounty assignee spot opens again, can I give it a try?

Hi @oscardavidrm I have already started work on this bounty as I got assigned to this issue, I think I will have this ready by the end of today :)

gall0x commented 2 years ago

Sorry, I didn't see someone was already working on it.

cjthompson commented 2 years ago

@0xdef1cafe - My personal preference would be to remove the splash screen entirely and default to using the app without a wallet. There is already a button in the upper-right to connect a wallet.

another option would be that rather than a full screen splash screen, a small modal could be shown over the app on first load.

I'm not a fan on the splash screen.

stackedq commented 2 years ago

@cjthompson with respect to UX perspective, I suggest removing splash screen. But opening up a modal on user arrival is really annoying, I believe the better workaround is to open the "connect wallet" modal after clicking wallet related CTA buttons.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 5750.0084 FOX (1954.43 USD @ $0.34/FOX) attached to this issue has been cancelled by the bounty submitter

gitcoinbot commented 2 years ago

⚡️ A tip worth 1000.00000 FOX (337.63 USD @ $0.34/FOX) has been granted to @amitojsingh366 for this issue from @0xean. ⚡️

Nice work @amitojsingh366! Your tip has automatically been deposited in the ETH address we have on file.

0xdef1cafe commented 2 years ago

awaiting mockups from product and can be rebountied as "demo mode"

0xean commented 2 years ago

Product to meet with @cjthompson on some wallet functionality before we move forward.

0xdef1cafe commented 2 years ago

requires https://github.com/shapeshift/hdwallet/issues/445 for implementation

mrnerdhair commented 2 years ago

The associated hdwallet PR is shapeshift/hdwallet#452 for reference

0xean commented 2 years ago

Pending a HD wallet release, this is ready for work to begin in web. @0xdef1cafe - to bounty out.

0xean commented 2 years ago

@0xf11nix - any interest in this one? We can get a bounty for you if so

0xf11nix commented 2 years ago

@0xf11nix - any interest in this one? We can get a bounty for you if so

@0xean. Sure, I'd love to take a crack at this one

LPX55 commented 2 years ago

Can we get a status update on this? Translation team has requested this feature to more easily access certain areas of the platform. @0xf11nix

0xf11nix commented 2 years ago

GM @LPX55!

My apologies for the delay in getting back to you on this one. We did have a couple of hiccups along the way relating to the spec/scope of the changes, but this has since been resolved.

Regarding an update on a timeline for release; I have now opened a PR (#1585), which is still in draft (pending a couple more changes before we can rollout to production), but we are on track for this being ready for a final review in the coming days.

I have been working with both Diggy and Lych over the last week or so, and will reach out to you personally once we have an ETA on next steps, and a timeline for rollout to production.

NeOMakinG commented 2 years ago

As a user, It feels a bit weird having to switch from the demo wallet to another wallet, I would probably expect to have a "Login" button instead of the wallet dropdown inside the navbar on the top right, reducing the wallet modal access to one action instead of 2, as disconnecting from the demo wallet makes no sense

gomesalexandre commented 2 years ago

As a user, It feels a bit weird having to switch from the demo wallet to another wallet, I would probably expect to have a "Login" button instead of the wallet dropdown inside the navbar on the top right, reducing the wallet modal access to one action instead of 2, as disconnecting from the demo wallet makes no sense

Agreed - a "Connect Wallet" button instead of the usual wallet dropdown would be a better UX for the demo wallet.

0xf11nix commented 2 years ago

Closing in favour of https://github.com/shapeshift/web/issues/1621