shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
157 stars 180 forks source link

Gracefully display assets without available market data #921

Closed tshifty closed 2 years ago

tshifty commented 2 years ago

Overview

Low ranked assets on CoinGecko have pricing information available on CoinGecko itself, but not via the API.

e.g. JACY via GUI vs JACY via API

If our market service is unable to fetch market data via CoinGecko, CoinCap, or Yearn, the asset page does not finish loading as shown.

Screen Shot 2022-02-03 at 5 37 00 PM

Acceptance criteria

Reference data

if (marketDataUnavailable) return <HangTightComponent />`

The following assets are known to be not working, and should be gracefully handled by your implementation.

Assets: These don't load: JACY (JACY) LaunchMyNFT (MYNFT) Lepasa (LEPA) - asset doesn't appear in prod Zamio (ZAMO) Keeps Coin (KPC) BlockchainSpace (GUILD) Pacific (PAF) Palette (PLT) - asset doesn't appear in prod Price chart doesn't load on 1h and 24h: Hackspace Capital (HAC) LADZ (LADZ) Price chart doesn't load on 1W and lower timeframe: Galactic Blue Index (GBI) Global DeFi (GDEFI) Habitat (HBT) Galaxer (GLX) Price chart doesn't load on 1M and lower timeframes: H3X (H3X) JBOX (JBX) Price chart doens't load on all timeframes: HALO (HALO) - asset doesn't appear in prod These don't load:

AAG Ventures (AAG) Baanx (BXX) BaaSid (BAAS) Bali Social Integrated (BSI) Ballswapper Acceler (BART) Capital DAO Protocal (CDS) Digifit (DGI) Price chart doesn't load on 1h and 24h:

BankCoin BCash (BCASH) BankEth (BANKETH) BANKEX (BKX) CAGE GOVERNANCE TOKEN (CGT)

Price chart doesn't load on 1W and lower timeframe: DDS Store (DDS) Earn Network (EARN) Price chart doens't load on all timeframes: Decentral Games (DG) pulltherug finance (RUGZ) 1m< not showing Nitrous Finance (NOS) 1w< not showing Direct Insurance To (DIT) 24h< not showing Ethereum Chain Toke (ECT) 1w< Also, sparklines not showing correct values. 1M only showing one day. 1Y and AT missing/skipping days. Freight Trust Netwo (EDI) 24h< not showing KRYZA Exchange (KRX) Aave inreest beari (AAMPL) ACU Platform (ACU) Acute Angle Cloud (ADINU) Again Project (AGAIN) Aggregated Finance(AGFI) Alien Inu (ALIEN) Alpha Brain Capital (ABC) Anduschain (DEB)

0xean commented 2 years ago

Asked product for expected behavior to make this a little more clear for the bounty hunter. will post once they respond.

amitojsingh366 commented 2 years ago

I can work on this :)

reallybeard commented 2 years ago

Mockup of an asset without market data: Screen Shot 2022-02-23 at 5 55 39 PM

Anywhere we display the value in fiat we that value should be removed, examples of this: Screen Shot 2022-02-23 at 5 55 44 PM

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 850.0 FOX (272.25 USD @ $0.32/FOX) attached to it as part of the ShapeShift fund.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 264 years, 7 months from now. Please review their action plans below:

1) erwanpapail has applied to start work _(Funders only: approve worker | reject worker)_.

This is a relatively simple issue but interesting though. I would love to work on it ! 2) 0xrowdy has applied to start work _(Funders only: approve worker | reject worker)_.

This looks relatively straightforward. Show alternative text describing the data issue or a component for this type of error. 3) trungtin has been approved to start work.

I have done other bounties in the web repo.

This one is straightforward, and I can do it promptly. 4) santosh1484 has applied to start work _(Funders only: approve worker | reject worker)_.

Yes I'm interested please provide free 5) ezhimakov has applied to start work _(Funders only: approve worker | reject worker)_.

I can handle this frontend problem and send a PR

Learn more on the Gitcoin Issue Details page.

0xean commented 2 years ago

@naftalimurgor - thanks for picking up the issue, can you let us know when you think you will be able to push a PR ? TY!

naftalimurgor commented 2 years ago

@0xean - Thanks. I'm thinking of submitting a PR in 5 days' time. Will submit a WIP PR as soon as I make progress on the changes am working on.

0xean commented 2 years ago

@naftalimurgor stopped work on the PR. We have selected @trungtin to take the next attempt. Thanks @trungtin !

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 850.0 FOX (301.3 USD @ $0.35/FOX) has been submitted by:

  1. @trungtin

@0xean please take a look at the submitted work:


0xean commented 2 years ago

@0xean - needs new bounty hunter

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 850.0 FOX (296.18 USD @ $0.35/FOX) attached to this issue has been cancelled by the bounty submitter

0xean commented 2 years ago

@purelycrickets to post to dework

gomesalexandre commented 2 years ago

Mockup of an asset without market data

@reallybeard could you add that to the description of the issue/ to #1555 as well? Both are not including clear A/C and it would help reviewers to have it in the issue description.