search

shapirov103 / cdk-eks-blueprint

repo for CDK Software Factory
Apache License 2.0
11 stars 2 forks source link

Audit addon file names #29

Open kcoleman731 opened 3 years ago

kcoleman731 commented 3 years ago

Rename Addon .ts files for consistency. I suggest either addon.ts or index.ts.

shapirov103 commented 3 years ago

do you suggest renaming all addon files to be addon.ts/index.ts? Does not sound like the most pressing thing, I can see benefits, such as consistency.

shapirov103 commented 3 years ago

@parkand1 can you take a look as a training task to debug the development process? We will need the following:

  1. rename all files on a branch
  2. update docs/internal-readme.md with clear rules on naming
  3. Create a PR to the main and me (and possibly Kevin) as approvers
kcoleman731 commented 3 years ago

Yep @shapirov103. If we leverage helm charts, we likely will only need a single file in each addon dir. I'm not too concerned about the actual name, just that we are consistent.