search

shapirov103 / cdk-eks-blueprint

repo for CDK Software Factory
Apache License 2.0
11 stars 2 forks source link

Audit Calico Addon #49

Open kcoleman731 opened 3 years ago

kcoleman731 commented 3 years ago

@shapirov103 lets talk about this addon. First lets get rid of the hard coded yaml file in favor of this helm chart

https://github.com/aws/eks-charts/tree/master/stable/aws-calico

Lets also set a version number.

shapirov103 commented 3 years ago

The question is: should not we use the official AWS documentation on Calico installation or do we favor a helm chart? The overhead from the maintenance perspective is the same. Plus the helm chart is more around installing Calico in full CNI mode, while the only pertinent distinction is helm upgrade --install --recreate-pods --force aws-calico --namespace kube-system eks/aws-calico. They also have a dependency on CRDs being installed for which they point to github repository which i don't think I can keep, so at least crds will have to stay yaml.

parkand1 commented 3 years ago

I personally think we should stick to the official AWS documentation on how to install Calico to provide a consistent experience for customers. I think it would provide the best experience for customers the less they have to worry about dependencies and the more they can rely on what we will end up providing out of the box.

shapirov103 commented 3 years ago

Right, I was leaning towards the AWS documented way since I am sure it is tested (hopefully continuously). The helm chart is probably also tested but by Tigera, but they don't provide a version matrix.

kcoleman731 commented 3 years ago

I'm dumb. Looks like we have official calico charts https://github.com/aws/eks-charts/tree/master/stable/aws-calico