search

shapirov103 / cdk-eks-blueprint

repo for CDK Software Factory
Apache License 2.0
11 stars 2 forks source link

EC2 Cluster Defaults #69

Open kcoleman731 opened 3 years ago

kcoleman731 commented 3 years ago

Add sensible defaults to the EC2ClusterProvider.

@shapirov103 please update this issue with the defaults you want.

We will also need to add documentation for this.

shapirov103 commented 3 years ago

Just FYI: current defaults are set in cdk.json as 

    "instanceType": "t3.medium",
    "vpc": null,
    "minSize": 1,
    "maxSize": 2,

BTW, this is also a way to use existing VPC instead of creating a new one. There is also support for default VPC if VPC is set to default, however, it must have 3 private subnets.

I still think defaults should be provided in the code if customer does have context set in cdk.json.