PresentationDetents and DragIndicatorVisibility are not applied after rotating the device

mwocu commented 1 year ago

Have you read the Contributing Guidelines?

Yes

General Information

Project version: v1.9.0 (latest release)
Platform/OS version: iOS 16 (Simulator, any device)
IDE version: Xcode 14.2

Describe the bug

After rotating the device from portrait to landscape and back, the PresentationDetents and the visibility of the DragIndicator are not applied correctly anymore.

Minimal reproduction

struct SheetView: View {
    @State private var showSheet = false

    var body: some View {
        Button("Show Sheet") {
            showSheet = true
        }
        .sheet(isPresented: $showSheet) {
            Color.red.edgesIgnoringSafeArea(.all)
                .backport.presentationDetents([.medium])
                .backport.presentationDragIndicator(.visible)
        }
    }
}

Steps to reproduce

Use the example code from above
Start app in portrait mode
Rotate to landscape and back to portrait
The sheet is now showing in .large mode and the drag indicator is hidden

Expected behavior

The sheet should still show up in .medium mode and the drag indicator should still be visible

Bugfix branch

I already fixed the bug in this branch https://github.com/mwocu/SwiftUIBackports/tree/fix_sheet_presentation_after_device_rotation and could submit a PR, if wanted https://github.com/shaps80/SwiftUIBackports/compare/main...mwocu:SwiftUIBackports:fix_sheet_presentation_after_device_rotation

shaps80 commented 1 year ago

would love this in a PR 👍🏻