search

shaps80 / SwiftUIBackports

A collection of SwiftUI backports for iOS, macOS, tvOS and watchOS
MIT License
960 stars 60 forks source link

toolbarBackground style modifier #49

Closed Alex293 closed 1 year ago

Alex293 commented 1 year ago

Hi, thanks for the nice work on the package !

I see that public func toolbarBackground<S>(_ style: S, for bars: ToolbarPlacement...) -> some View where S : ShapeStyle is commented, what is blocking/missing for making it usable ?

shaps80 commented 1 year ago

I attempted working on this, it proved to be quite difficult to backport without issues/bugs being introduced. Particularly surrounding how largeTitle backgrounds work during scroll events.

I didn't have the time to investigate further, but I did spend a fair amount of time (failing) trying to implement this.

To me, it looks unlikely I'm afraid. If you decided to continue/attempt this please test carefully across all potential uses of the toolbar (even if its just iOS) – thanks!

Alex293 commented 1 year ago

Thanks for the quick response. I'm evaluating if it's worth the effort compared to make a custom navbar for our app. I'll try investigating and report here if I find a working solution.

Alex293 commented 1 year ago

Just FYI I have something which seems to work nicely but I used SwiftUIIntrospect instead of your tools for introspection. When every thing is working as intended I'll try to switch back to your tools and PR.

shaps80 commented 1 year ago

Yeah mines essentially a refactor of that library, I felt it simplifies some of the APIs in that library. Regardless I don't want to include any other dependencies so that's why I did it this way. Thanks!