Closed JosephDuffy closed 2 years ago
Yeah, I basically include the basic mechanism only for now. I had intended to explore this and I in fact have it listed (need to add my list to GH Issues 😬). I'll check it out thanks!
@JosephDuffy FYI that other repo uses Introspect, which I was trying to avoid (3rd party libs) for these backports. That's literally the reason I didn't include it yet. literally changed List
to UICollectionView
this year, and while backports wouldn't be affected, its still problematic because diff iOS versions often have subtle differences behind SwiftUI. Especially environment based stuff 💀
One other note, I needed to backport ProgressView
first as well, so that was another reason I bumped the core-implementation, preferring to explore pull-to-refresh options later on.
I also wanted to backport ScrollViewReader
beforehand, because that felt somehow like the internal implementation I might build, may contribute to a working solution 👍
1.3.0
now includes this @JosephDuffy :)
Awesome! I'll try it out soon :)
Have you read the Contributing Guidelines?
General Information
Project version: 1.0.9
Platform/OS version: iOS 14.0.1, iOS 15.5, iOS 16
IDE version: Xcode 13.4.1, Xcode 14 beta 2
Devices: iPhone Simulator
Any related GitHub issues: N/A
Describe the bug
Using
.backport.refreshable
does not add pull-to-refresh to a list.Steps to reproduce
Add
.backport.refreshable
to aList
.Expected behavior
Should add pull-to-refresh to the list.
Stack trace, compiler error, code snippets
Screenshots
Additional context
It could be argued that the backport is complete; it does set the environment value. But not adding the pull-to-refresh was a surprise to me. It does look to be possible (https://github.com/Geri-Borbas/iOS.Package.Refreshable) so maybe something similar could be added?