search

shaqian / flutter_ssh

SSH and SFTP client for Flutter
https://pub.dartlang.org/packages/ssh
MIT License
117 stars 83 forks source link

SSHClient disconnect never completes #5

Closed pbaker5 closed 5 years ago

pbaker5 commented 5 years ago

On both iOS and Android, disconnect never completes.

This happens even for a simple use case of:

SSHClient _client; await _client.connect(); await _client.disconnect();

I'm on Flutter Channel dev, v1.1.8, on Mac OS X 10.14.3.

shaqian commented 5 years ago

Hi,

Sorry for the late reply. Is this resolved by your PR? I merged it in v0.0.3.

Thanks, Qian

pbaker5 commented 5 years ago

No.

nikitiuk0 commented 5 years ago

+1 The disconnect never happens.

shaqian commented 5 years ago

Thank you for the feedback.

I forgot that disconnect method doesn't return result from native code. https://github.com/shaqian/flutter_ssh/blob/master/ios/Classes/SshPlugin.m#L455

The dart code should not be async. I will fix this in next version.

ronpetit commented 5 years ago

Any updates on this? @shaqian I don't like to just leave it there without disconnection.

I don't understand that .m file, I would like to help

SunLongbri commented 5 years ago

I never connect server by SFTP , and the ip , host ,username,pass are all correct.Some tiem later, the app creshed and exit.

shaqian commented 5 years ago

Sorry for the delay. The fix is in v0.0.4.

Thanks, Qian