search

shaqian / tflite-react-native

React Native library for TensorFlow Lite
https://www.npmjs.com/package/tflite-react-native
MIT License
289 stars 108 forks source link

Update to RN0.60 #13

Open kaelhem opened 5 years ago

kaelhem commented 5 years ago

Hello, Thanks a lot for your library, it's awesome !

In this pull request I did several small things to make it compatible with the last version of react native. Here is a comprehensive list of what I did :

With these changes, I was able to successfully build the example app on both iOS & Android on react-native 0.65 !

Let me know if you have questions / remarks.

ghost commented 5 years ago

Is it possible to change the Podfile dependency from "TensorFlowLite" to "TensorFlowLiteObjC". The former library is a bit outdated and doesn't support models created in newer version of TFlite

You can find some documentation on it here: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/experimental/objc

kaelhem commented 5 years ago

In fact, I tried to update to TensorFlowLiteObjC v1.14.0, but the library is very different and the documentation very poor. I suppose that an obj-c/swift developer could do something to make it work...

shaqian commented 4 years ago

Hi kaelhem,

Thanks a lot for making the library work with RN0.60!

Would these changes break RN < 0.60?

Thanks, Qian

kaelhem commented 4 years ago

Hi shaqian, With RN 0.60, iOS projects uses cocoapods and android ones are based on AndroidX. Because of that, project templates are quite different, so yes, I suppose these changes will break with RN <0.60.

Cheers, kaelhem

rafaelcavalcante commented 4 years ago

Any updates on this?

kaelhem commented 4 years ago

not on my side... I moved on, sorry.

TuJobs commented 3 years ago

Why isn't the library updated, can we annotate the library version with react-native version?

utkarsh867 commented 3 years ago

@shaqian Hoping that we can move the package on to RN 0.60 and later using this PR.