why make this xrp-specific?

sharafian / ilp-plugin-xrp-asym

Moved

0 stars 0 forks source link

why make this xrp-specific? #3

Closed michielbdejong closed 6 years ago

michielbdejong commented 6 years ago

I love the idea of providing a module that acts as many server-side paychan plugins, because that's what a connector will usually have. But do I understand correctly that this repo is xrp-specific? Could we "multiply" other ilp-plu-pa-cha-fra-based plugins in the same way?

sharafian commented 6 years ago

yeah, it's not actually based on payment-channel-framework anymore now that it's on the new LPI, but ilp-plugin-btp contains a generic BTP plugin that can be built off of for payment channel based plugins. We could restructure ilp-plugin-mini-accounts a little bit, and that would allow us to use that to generically create server-side plugins for many different ledgers

michielbdejong commented 6 years ago

OK, so if I understand correctly:

ilp-plu-pa-cha-fra is deprecated
ilp-plugin-btp is its successor
to that, mini-accounts will add a multi-connection WebSocket server on the server-side
once you have plugin-btp + mini-accounts on the server-side, this repo only needs to add the xrp-specific things

But for now it also does part of plugin-btp's and mini-accounts's job. Right?

sharafian commented 6 years ago

yeah, that's correct

sharafian commented 6 years ago

now that the ilp-plugin-asym-server inherits ilp-plugin-mini-accounts, I think this is resolved. The base classes that can be extended are now ilp-plugin-btp and ilp-plugin-mini-accounts