search

shardeum / shardus-core

Other
10 stars 2 forks source link

GOLD-145 : AJV addition and verification data check: binary_get_account_data_by_list #216

Closed abdulazeem-tk4vr closed 1 month ago

abdulazeem-tk4vr commented 1 month ago

https://linear.app/shm/issue/GOLD-145/ajv-addition-and-verification-data-check-binary-get-account-data-by#comment-33711313

github-actions[bot] commented 1 month ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Code Consistency
The import of `AJVSchemaEnum` and its usage in `verifyPayload` replaces a hardcoded string. Ensure all other similar instances in the project follow this pattern for consistency. Enum Extension
The `AJVSchemaEnum` has been extended with `GetAccountDataByListReq` and `GetAccountDataByListResp`. Verify that these new enums are correctly utilized wherever relevant throughout the project to maintain uniformity.