shardeum / shardus-core

Other
10 stars 2 forks source link

Gold AJV and Internal endpoint hardening for review #228

Closed afostr closed 1 month ago

github-actions[bot] commented 1 month ago

PR Reviewer Guide ๐Ÿ”

โฑ๏ธ Estimated effort to review: 5 ๐Ÿ”ต๐Ÿ”ต๐Ÿ”ต๐Ÿ”ต๐Ÿ”ต
๐Ÿงช No relevant tests
๐Ÿ”’ No security concerns identified
โšก Key issues to review

Schema Update
The schema for `CompareCert` has been significantly expanded with new properties and requirements. Ensure that these changes are compatible with the existing data structures and that all new fields are appropriately validated. Payload Verification
The payload verification now uses `AJVSchemaEnum.GetAccountDataReq` instead of a string identifier. Confirm that all schema identifiers have been correctly updated throughout the project to prevent runtime errors.