search

shardeum / shardus-core

Other
10 stars 2 forks source link

GOLD-209 : resolve issue of possibly not responding handler when timestamp receipt is null #230

Closed abdulazeem-tk4vr closed 4 weeks ago

abdulazeem-tk4vr commented 1 month ago

https://linear.app/shm/issue/GOLD-209/resolve-issue-of-possibly-not-responding-handler-when-timestamp

github-actions[bot] commented 1 month ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Error Handling
The new error handling logic in lines 363-372 could potentially suppress the original intent of the function by not allowing further processing if the timestamp is null. This change might affect other parts of the system relying on the original behavior where a response was still sent even if the timestamp was null.
jintukumardas commented 4 weeks ago

@abdulazeem-tk4vr Changes look good. Has this been tested?