search

shardeum / shardus-core

Other
10 stars 2 forks source link

RED-235: add queueLengthAll and tx age buckets to report #232

Closed urnotsam closed 4 weeks ago

github-actions[bot] commented 1 month ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Variable Redefinition
The variable `queueLength` is redefined from `executeQueueLength` to `queueLengthAll` without clear documentation on why this change is necessary. This might introduce bugs or confusion about the data being reported. Performance Concern
The method `getQueueLengthBuckets` iterates over the entire transaction queue and performs time calculations on each iteration. This could be a performance bottleneck, especially with a large number of transactions. Consider optimizing this calculation or caching results.
mhanson-github commented 4 weeks ago

This was cherry picked over to dev since it was in the RC mainline.