RED-247: Add null check for `queueEntry` when getting index value in the TransactionQueue processing loop

shardeum / shardus-core

Other

10 stars 2 forks source link

RED-247: Add null check for `queueEntry` when getting index value in the TransactionQueue processing loop #233

Closed dnlbui closed 2 weeks ago

dnlbui commented 1 month ago

https://shardeum.slack.com/archives/C07F5L9TF33/p1723222226341989?thread_ts=1723210967.343049&cid=C07F5L9TF33 Above is the ask

Summary: Add null check for queue entry in TransactionQueue processing loop

Prevent potential null error causing node to error out
Log error and skip to next transaction if queue entry is null

github-actions[bot] commented 1 month ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review

Code Style
The null check for `queueEntry` is added without any spacing between the `if` statement and the condition. It is recommended to add a space after `if` for better readability.