search

shardeum / shardus-core

Other
10 stars 2 forks source link

BLUE-212 Fix the issue of original standby nodelist data getting mutated due to standbyRefresh nodes #239

Closed jairajdev closed 2 weeks ago

github-actions[bot] commented 1 month ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Code Clarity
The use of `deepCopy` for `lastHashedList` is introduced to avoid mutation issues. However, it's important to ensure that `deepCopy` is thoroughly tested and efficient, as deep copying can be resource-intensive. Consider adding performance tests if not already present.
afostr commented 2 weeks ago

we applied a workaround fix 0cda7f00ce800b27b7bd1541e8696252e1a87d5e