search

shardeum / shardus-core

Other
10 stars 2 forks source link

Allow additional properties in CycleRecord AJV #242

Closed arhamj closed 1 week ago

arhamj commented 1 month ago

https://linear.app/shm/issue/GOLD-215

Made the check of properties more lenient for cycle record in compare cert AJV check.

github-actions[bot] commented 1 month ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Key issues to review

Schema Change
The schema for CompareCert has been significantly altered by removing many properties and changing the 'required' fields. This could potentially break existing functionality if other parts of the application rely on these removed fields. Additional Properties
Allowing additional properties in the CompareCert schema (`additionalProperties: true`) may lead to unexpected data being accepted without validation, which could cause issues in data processing or storage.
mhanson-github commented 1 week ago

In dev.