search

shardeum / shardus-core

Other
10 stars 2 forks source link

pri-55. work from Sonali, had to extract from a merge commit #251

Closed afostr closed 3 weeks ago

github-actions[bot] commented 3 weeks ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Key issues to review

Error Handling
The function `deserializeSignAppDataReq` throws a generic error message for version mismatch. It would be more informative to include the expected and actual versions in the error message. Error Handling
Similar to `SignAppDataReq`, the `deserializeSignAppDataResp` function should include more detailed error information regarding the version mismatch.