search

shardeum / shardus-core

Other
10 stars 2 forks source link

PRI-54 : Prevent front running initial account data distribution #252

Closed abdulazeem-tk4vr closed 1 week ago

abdulazeem-tk4vr commented 3 weeks ago

linear : https://linear.app/shm/issue/PRI-54 removing broadcast_state_complete_data, timestamp cache and spreading appliedVote image

github-actions[bot] commented 3 weeks ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Commented Code
The entire block of code related to 'remove_timestamp_cache' is commented out. If this code is not needed, it should be removed to keep the codebase clean. Commented Code
The block of code for 'broadcast_state_complete_data' is commented out. Similar to other files, if this is intended to be removed or refactored, it should not be left as commented out to maintain clarity. Commented Code
The method 'spread_appliedVote' is commented out. Ensure that if this functionality is deprecated or refactored, the code is removed or properly updated rather than left commented.