PRI-41, 5sec timeout for external http endpoints

shardeum / shardus-core

Other

19 stars 3 forks source link

PRI-41, 5sec timeout for external http endpoints #254

Closed kgmyatthu closed 1 month ago

kgmyatthu commented 2 months ago

The old PR didn't let me reopen after a force push.

github-actions[bot] commented 2 months ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review

Hardcoded Value
The timeout value is multiplied by 1000, assuming the configuration is in seconds. This could lead to confusion or errors if the configuration unit changes. Consider adding a comment or using a more descriptive variable name to clarify that the configuration should be provided in seconds.

kgmyatthu commented 1 month ago

This one need spcial case care and longer duration. Please hold the PR