shardeum / shardus-core

Other
10 stars 2 forks source link

GOLD-211: ECDSA Multi-sig feature #258

Closed arhamj closed 2 weeks ago

arhamj commented 2 weeks ago

Task: https://linear.app/shm/issue/GOLD-211/

github-actions[bot] commented 2 weeks ago

PR Reviewer Guide ๐Ÿ”

โฑ๏ธ Estimated effort to review: 4 ๐Ÿ”ต๐Ÿ”ต๐Ÿ”ต๐Ÿ”ตโšช
๐Ÿงช No relevant tests
๐Ÿ”’ No security concerns identified
โšก Key issues to review

Configuration Consistency
The PR introduces new configurations for multi-signature keys and requirements (`multisigKeys`, `minMultiSigRequiredForEndpoints`, `minMultiSigRequiredForGlobalTxs`). It's crucial to ensure that these new settings are consistent with the existing system configurations and that they are being used correctly throughout the application. Security Validation
The new methods `ensureMultisigKeySecurity` and `verifyMultiSigs` are added to handle multi-signature validation. It's important to thoroughly review these methods to ensure they correctly implement the intended security checks without introducing vulnerabilities. Middleware Authentication
Changes in middleware to support multi-signature authentication (`handleDebugMultiSigAuth`) need careful examination to ensure that they correctly authenticate requests and handle errors without allowing unauthorized access or information disclosure. Method Implementation
The implementation of `verifyMultiSigs` in the `Shardus` class should be reviewed for correctness and to ensure it integrates properly with the rest of the application's architecture.