Open Quintasan opened 1 year ago
Mainly looks good just needs a few minor changes. The main thing is that I'd say the
pry-byebug
dependency isn't really needed and goes way beyond the scope of this PR.
We should be good to go now
Mainly looks good just needs a few minor changes. The main thing is that I'd say the
pry-byebug
dependency isn't really needed and goes way beyond the scope of this PR.We should be good to go now
Almost there, I think you forgot to remove the dependency from the spec dependency though 😅
Mainly looks good just needs a few minor changes. The main thing is that I'd say the
pry-byebug
dependency isn't really needed and goes way beyond the scope of this PR.We should be good to go now
Almost there, I think you forgot to remove the dependency from the spec dependency though 😅
Derp, done
@Droid00000 well, this should be good now
Looks great! It could be interesting to use this PR to further implement message flags (in a similar way to how the permissions class is currently structured). This is what I came up with: https://gist.github.com/wouterdedroog/59ed3076558c6d943dca5f8c75d5437f
Summary
pry-byebug
to development dependenciesAPI::Channel#suppress_embeds
Message#suppress_embeds