search

shardlab / discordrb

Discord API for Ruby
MIT License
536 stars 98 forks source link

Add base64 gem explicitly as dependency #263

Closed mataku closed 1 month ago

mataku commented 5 months ago

Summary

closes https://github.com/shardlab/discordrb/issues/256

base64 is no longer the default gem from Ruby 3.4 https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/

On Ruby 3.3, we could see the warning:

warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.

From Ruby 3.4, we will get the error:

Failure/Error: require 'base64'

LoadError:
  cannot load such file -- base64

Added

Add base64 dependency to gemspec

mataku commented 1 month ago

@swarley please review and let me know if you have any questions

PixeLInc commented 1 month ago

This fix was included in another PR that was merged: https://github.com/shardlab/discordrb/pull/277

so going to close this one out. Thanks for the PR, though.