Updated POM.XML: Include resources in META-INF/

share-extras / media-viewers

Enhanced document previews for a range of different document and media types, plus a dashlet allowing any content item to be displayed on a site dashboard.

Apache License 2.0

29 stars 23 forks source link

Updated POM.XML: Include resources in META-INF/ #37

Closed miroslav-beranic closed 6 years ago

miroslav-beranic commented 10 years ago

CHANGES:

Include Web Resources in JAR as in META-INF/ directory
Remove WAR plugin, as it is not used: this is JAR
Sync artifact version number, to be the same as ANT build
Consider using parent Maven project

I guess AMP has similar problems. I have not checked yet, as I do not use AMP-s (at all).

You should compare produced JAR-s build with Ant and Maven. They should/must be the same size and structure. For more info, I am available on my email.

miroslav-beranic commented 10 years ago

Testing resource: http://localhost:8080/share/res/extras/components/preview/MP3Player.js .. spin.js .. Embed.js

I run Share in different configuration, but this should be the same in "out of the box" deployment.

Without "my changes" I get HTTP 404. It there is a better solution - I would like to know about it. Thanks

wabson commented 10 years ago

Thanks for the pull request, however I think you have made the assumption that the pom inside the project is intended for building the source. In fact it is only used to define the metadata needed to install and deploy the packages that are built using the Maven Ant Tasks, and as you suggest some changes are needed in order to build the project itself using Maven.

This could be a nice enhancement, for folks who want to build entirely using Maven and who are willing to accept the risks. Can you confirm that with your changes you are able to produce a JAR file that meets your definition of acceptable above (same size and structure)?

miroslav-beranic commented 10 years ago

I agree, I guess I did not say the whole story ... I use Maven for everything regarding Alfresco, and I do not use Ant build scripts (if I can avoid them ...).

I have checked and I missed one file: alfresco/site-data/extensions/org_sharextras_media-previews.xml (@VERSION@ is not updated/changed - from what I know, this is done by the Ant build script)

Other files are the same.

I will update/fix this and make another pull request. I guess this pull request can be closed.

BTW: HNY and all the best in 2014.

miroslav-beranic commented 10 years ago

Hi! I am new to "pull requests" and all this. I have noticed, I do not have to send new "pull request". So, I have updated/fixed pom.xml. Now I call/execute Ant Build scripts in build.xml and project.xml

Commit: cc9b856d0fd667732ff85347fd8a9b656c7e0c99

Resulting in "identical" result JAR file. Difference is in MANIFEST.MF - Since it is build with Maven and not with Ant. But all in all, JAR files are the same.