search

share-extras / media-viewers

Enhanced document previews for a range of different document and media types, plus a dashlet allowing any content item to be displayed on a site dashboard.
Apache License 2.0
29 stars 23 forks source link

Configurable if the "View in browser" bar should be produced. #44

Open gugrim opened 10 years ago

gugrim commented 10 years ago

In source/web/extras/components/preview/Embed.js, function Embed_display(), the "View in browser" bar is produced. I don't like it so I remove it but it would be nice if it was configurable.

The reason I don't like it is that I don't think if fills a purpose since the function is available anyway and the HTML contens looks better wihout it.

wabson commented 10 years ago

This sounds like a useful feature. Are you able to implement this and send a pull request?

gugrim commented 10 years ago

Don't know about the "configurable" part but I'll have a look at it.

Gunnar Grim Knowit Karlstad AB

From: Will Abson notifications@github.com Sent: Wednesday, March 05, 2014 14:46 To: share-extras/media-viewers Cc: Gunnar Grim Subject: Re: [media-viewers] Configurable if the "View in browser" bar should be produced. (#44)

This sounds like a useful feature. Are you able to implement this and send a pull request?

Reply to this email directly or view it on GitHubhttps://github.com/share-extras/media-viewers/issues/44#issuecomment-36743093.