Fixes to op version tracking

ZechyW commented 6 years ago

When the ShareDB backend commits an op/snapshot pair, the version of the snapshot is always 1 higher than the version of the op.

When checking for the maximum current snapshot version, we should therefore query the snapshots table directly, not the ops table.
When committing ops, we should therefore also use op.v, not snapshot.v. If we use snapshot.v, the version field in the ops table will contain a different number from the JSON representation of the op in the operation field. (This is precisely what happens with the current version of the library.)
When getting a range of operations with .getOps(), I found that rows were sometimes being returned out of order; adding an explicit ORDER BY clause to the query fixes the issue.

huntj88 commented 4 years ago

Is this branch stable, or ever going to be reviewed? It supports jsonb which is what i'm looking for

alecgibson commented 1 week ago

Thanks for the submission. I'm closing this as it's pretty old. The driver should now be fully compliant with ShareDB database driver specs as of https://github.com/share/sharedb-postgres/pull/24

Please feel free to reopen if I've missed something.

share / sharedb-postgres