sharebrained / portapack-hackrf

Portability Add-On for the HackRF Software-Defined Radio.
GNU General Public License v2.0
994 stars 408 forks source link

Fix for capture hanging on exit #159

Closed eried closed 4 years ago

eried commented 4 years ago

Fix for capture app getting stuck when exiting without stoping the recording

jboone commented 4 years ago

Thanks for this, and for taking on maintenance of your fork! Is it applied in the latest release (v1.0.2) of Mayhem? I'm still seeing freezes on exit from the Capture app, and the Audio app. I'll review your recent commits and build your master and see if the issue is resolved there.

jboone commented 4 years ago

Ah yep, looks like the fix was after the 1.0.2 release. I'll build Mayhem master, and double-check it, and also check the Audio app. If it happens there too, I'll put together a patch for that and send it back at you.

sck-nogas commented 4 years ago

Dohh, I was just about to reply with a link to the commit. :)

https://github.com/eried/portapack-mayhem/commit/acbb100d64a45c302c18442542d1519e0aa5c136

jboone commented 4 years ago

@eried Looks like it's resolved in both places. Thank you!

jboone commented 4 years ago

The same issue exists on Replay. I'll put together a fix.

eried commented 4 years ago

Thanks for this, and for taking on maintenance of your fork! Is it applied in the latest release (v1.0.2) of Mayhem? I'm still seeing freezes on exit from the Capture app, and the Audio app. I'll review your recent commits and build your master and see if the issue is resolved there.

Btw, the latest nightly (on releases) after that commit was with the fix (will be on 1.0.3, but after a few more fixes)