matched feature lines are drawn using mapbox styles; no longer with mapbox-gl-draw
matched feature lines are draw in a new color (#253EF7) and offset slightly to account for multi-directional roads
triangle icons indicating directions added along each matched feature line. there is some work to do here as the icons are placed at the midpoint of the first and last point of each line, which might result in weird placement for long, curved roads
condensed left hand side group items
ability to zoom into matched feature line groups:
ability to highlight matched feature line groups & individual feature lines by hovering over corresponding sections in left-hand side menu:
ignoreDirection is now false when matching feature lines. now, the order of points selected matters (both ways of 2-way streets not automatically selected).
grouping algorithm now:
groups by exact match of streetname value (this will update as streetname value changes)
does not group 2-way streets together. this is largely because direction proves to be somewhat unreliable as a way to group streets (street segment A can be forward but its adjacent street segment B —the continuation of the roadway—can be backward)
splits up groups that contain an intersection with more than 2 streets going to/from that intersection.
so now instead of this:
you should generally see something like this:
unit tests for grouping algorithm + static geojson files to test against
directional toggling disabled in all situations, since two-way streets are no longer grouped together & streets are selected by their drawn direction
added a confirmation button to renaming streetname values. since grouping now takes into account streetname value, updating app state onChange causes lots of repaint in the UI. for now, the solution here is to add a confirmation button. there is still some UX work to do here but the button indicates the user should expect a change:
indraneel
commented
5 years ago
changes included in this (far too big) PR:
matched feature lines are drawn using mapbox styles; no longer with mapbox-gl-draw
matched feature lines are draw in a new color (#253EF7) and offset slightly to account for multi-directional roads
triangle icons indicating directions added along each matched feature line. there is some work to do here as the icons are placed at the midpoint of the first and last point of each line, which might result in weird placement for long, curved roads
condensed left hand side group items
ability to zoom into matched feature line groups:
ability to highlight matched feature line groups & individual feature lines by hovering over corresponding sections in left-hand side menu:
ignoreDirectionis nowfalsewhen matching feature lines. now, the order of points selected matters (both ways of 2-way streets not automatically selected).grouping algorithm now:
directionproves to be somewhat unreliable as a way to group streets (street segment A can beforwardbut its adjacent street segment B —the continuation of the roadway—can bebackward)unit tests for grouping algorithm + static geojson files to test against
directional toggling disabled in all situations, since two-way streets are no longer grouped together & streets are selected by their drawn direction
added a confirmation button to renaming streetname values. since grouping now takes into account streetname value, updating app state
onChangecauses lots of repaint in the UI. for now, the solution here is to add a confirmation button. there is still some UX work to do here but the button indicates the user should expect a change: