Firefox social Services API addition requires being on https version of page

sharetodiaspora / sharetodiaspora.github.io

diaspora* Advanced Sharer - Share links and posts to your favorite diaspora* pod.

sharetodiaspora.github.io

GNU Affero General Public License v3.0

23 stars 12 forks source link

Firefox social Services API addition requires being on https version of page #14

Closed jaywink closed 9 years ago

jaywink commented 9 years ago

Clicking the button to enable service does nothing at least on Firefox developer edition 40 if not on HTTPS version of the page.

How can this be dealt with on gh-pages?

fdavidcl commented 9 years ago

It looks like GitHub cannot be forced to use HTTPS by default, but there's this guide on how to redirect users to HTTPS. I'll give it a try.

fdavidcl commented 9 years ago

It seems to work fine now on Firefox Developer Edition. The HTTPS redirection is currently only enabled for the about page. Should it affect the main page as well?

jaywink commented 9 years ago

Great, thanks @fdavidcl for your awesome work with this! :cookie:

I'm not sure it needs to be on the normal pages, I guess HTTPS is always good, so I don't see any harm. But I'll close this issue from here as it's solved.