search

sharetribe / web-template

Sharetribe Web Template - starting point to create a client app to your marketplace
Other
31 stars 136 forks source link

Missing payout details banner not showing for 'purchase' #442

Closed thibautlagarde closed 2 months ago

thibautlagarde commented 2 months ago

Hi Sharetribe,

I've probably found an issue in the codebase regarding the missing payout details banner displayed on Listing Pages.

Files: src/containers/ListingPage/ListingPageCoverPhoto.js line 205 src/containers/ListingPage/ListingPageCarousel.js line 202

const processType = isBooking ? ('booking' ? isPurchase : 'purchase') : 'inquiry'; This caused the noPayoutDetails banner to never show for purchases.

I fixed it with this const processType = isBooking ? 'booking' : isPurchase ? 'purchase' : 'inquiry';

Thanks!

Gnito commented 2 months ago

Thanks! It seems I haven't reviewed incoming changes properly.

Gnito commented 2 months ago

https://github.com/sharetribe/web-template/pull/443

Gnito commented 2 months ago

The suggested fix is now merged to the main branch. I'll close this issue.