sharingio / pair

A shareable pairing environment
https://pair.sharing.io
Apache License 2.0
11 stars 1 forks source link

Update handling of SSH keys for GitHub accounts #163

Closed BobyMCbobs closed 2 years ago

BobyMCbobs commented 2 years ago

Currently some users of Pair are experiencing a 502 when trying to log in. This behaviour has begun since these changes https://github.com/sharingio/pair/compare/fdc243649284060cbd881adbd9867f2327f2394f...b6653aa374b9e28435b03a2db742e693e60df7a7 Since the auth is in the github.clj and that was the only file that was modified to do with it, this issue must be to do with this file. In investigating this issue, the function for getting SSH keys is different to all the other ones, where it using a try-catch mechanism. I suspect that the behaviour is slightly different to the other functions.

Co-Authored-By: robertkielty robertkielty@users.noreply.github.com