search

shariqfarooq123 / AdaBins

Official implementation of Adabins: Depth Estimation using adaptive bins
GNU General Public License v3.0
725 stars 156 forks source link

what is focal for in train_files_with_gt.txt #49

Closed ynjiun closed 2 years ago

ynjiun commented 2 years ago

Hi @shariqfarooq123

Very nice work!

I noticed that in both kitti and nyu train/test_files with_gt.txt there is a column of focal values. In nyu the focal value is a constant 518.8579 But in kitti the focal values are ranging from 707.0912 to 721.856. What is focal? Is it camera focal length? in what unit? (mm, or pixel)? Are focal values used in training the model?

The reason I asked these questions is if I want to train the model with my own datasets, do I need to provide focal value? if the model doesn't really use it for training/testing, could I just give an arbitrary number?

Thanks a lot for your help.

JBYan commented 2 years ago

I also wonder why focal value was added, did you figure it out? @ynjiun

I noticed that in both kitti and nyu train/test_files with_gt.txt there is a column of focal values. In nyu the focal value is a constant 518.8579 But in kitti the focal values are ranging from 707.0912 to 721.856. What is focal? Is it camera focal length? in what unit? (mm, or pixel)? Are focal values used in training the model?

shariqfarooq123 commented 2 years ago

The focal values are not used for training the AdaBins model. Its used in the previous work from which the dataloaders are directly taken.