search

sharish / CreditCardView

Apache License 2.0
968 stars 246 forks source link

Added logo and detection for Discover cards #43

Closed dcchristopher closed 6 years ago

dcchristopher commented 6 years ago

Continuing on the existing theme, I added the reg ex pattern and UI logo for Discover cards.

dcchristopher commented 6 years ago

I don't know why there is a preset style (e.g., CardSelector.VISA, etc) for each card type yet it then gets overridden once the third digit is entered (hashCode, override chip inner/outer, etc). I would personally eliminate that part of the code in CardSelector.selectCard(String cardNumber). That's a call for @sharish to make.