search

sharish / CreditCardView

Apache License 2.0
968 stars 246 forks source link

American Express Cards #9

Open cpiggott opened 8 years ago

cpiggott commented 8 years ago

American Express card numbers are usually 14 digits long and have a different format for the CVV. The American Express CVV is a 4 digit number, might be good to account for these.

Also, it might be good to conform to the IIN numbers that can be seen at this Wiki page: https://en.wikipedia.org/wiki/Bank_card_number

Great product, keep up the great work. I'll try and fix this myself and sent a PR, wanted to let you know that these exist.

sharish commented 8 years ago

Thanks Chris for the info. Will accommodate the american express with four digit CVV / 14 digit card numbers.

Right now it is not existing, send a PR if you have fixed.

Thanks, Harish

cpiggott commented 8 years ago

I haven't had enough time to dive down into the code to figure out how to accommodate for it. If I work on it, it will be in about two weeks.

Regards, Chris

sharish commented 8 years ago

Even I might take two weeks. Will update you if I'm working on.

Thanks, Harish

ubarua123 commented 7 years ago

Has anybody worked on this? :)

cpiggott commented 7 years ago

I haven't.

viralmoonlight commented 7 years ago

Created a pull request for this.

sharish commented 7 years ago

Four digit CVV implemented with #21. 14 digit card number pending for this issue to be resolved.

dcchristopher commented 7 years ago

Added PR to address AMEX cards. Enjoy!