search

sharkdp / bat

A cat(1) clone with wings.
Apache License 2.0
49.35k stars 1.25k forks source link

Add Support for Rusty Object Notation (RON) #2427

Closed kamaaina closed 1 year ago

kamaaina commented 1 year ago

Syntax: RON - Rusty Object Notation - https://github.com/ron-rs/ron

Guideline Criteria: https://packagecontrol.io/packages/RON

keith-hall commented 1 year ago

Forgive the silly question: I see RON is designed to be similar to Rust syntax - can we not just map RON files to the Rust syntax definition? It would be preferable to bundling another syntax, especially one that isn't super popular. Or is there something that wouldn't get highlighted correctly?

kamaaina commented 1 year ago

yup, i too think that will work (mapping RON to rust syntax). mahalo!

ghost commented 1 year ago

yes, this seems to work fine (see attached image). could i just fork and pr after making it do the same thing for ron as it does for rust? it seems that'd be a pretty trivial change, after all. image

keith-hall commented 1 year ago

yes, this seems to work fine (see attached image). could i just fork and pr after making it do the same thing for ron as it does for rust? it seems that'd be a pretty trivial change, after all. image

yes, PRs are welcome :) note that the Rust syntax definition comes from a submodule which we can't update at the moment, so your choices are to make a patch for it (i.e. similar to https://github.com/sharkdp/bat/blob/master/assets/patches/Groff.sublime-syntax.patch) or add it to https://github.com/sharkdp/bat/blob/master/src/syntax_mapping.rs.

peppermenta commented 1 year ago

Hi

Can I work on this?

Horgix commented 1 year ago

:wave: Hi, I was looking into good first issues to contribute on, and I believe this one can be closed given it was solved by #2642 , doesn't it? Just figured i would notify along the way :slightly_smiling_face:

Enselic commented 1 year ago

Indeed, thanks 🙂