search

sharkdp / fd

A simple, fast and user-friendly alternative to 'find'
Apache License 2.0
34.25k stars 816 forks source link

conda-forge package #1538

Closed flaviomartins closed 6 months ago

flaviomartins commented 7 months ago

Please consider providing a package for fd on conda-forge

tmccombs commented 6 months ago

It looks like https://conda-forge.org/docs/maintainer/adding_pkgs/#creating-recipes is the instructions on how to do this.

Bascially, it looks like you need to make a PR to a staging repo for conda-forge with a "recipe" for this package.

flaviomartins commented 6 months ago

I am working on this on https://github.com/conda-forge/fd-find-feedstock/pull/24

The osxarm64 build test is failing with Bad CPU type in executable.

@sharkdp I see there are no osx_arm64 binaries on the v10.0.0 release. Should it build?

tmccombs commented 6 months ago

See https://github.com/sharkdp/fd/issues/1088

I'm not sure what is going wrong in your case. Maybe it is compiling using the wrong rust target? for osx_arm64 you need to use the aarch64-apple-darwin target for the rust toolchain. But I'm not sure where that is set in the conda-forge config.

flaviomartins commented 6 months ago

See #1088

I'm not sure what is going wrong in your case. Maybe it is compiling using the wrong rust target? for osx_arm64 ou need to use the aarch64-apple-darwin target for the rust toolchain. But I'm not sure where that is set in the conda-forge config.

It was failing when running the test. I skip the test now for arm64 since the test will be running on x86_64 where the cross compilation took place (not sure if azure pipelines has aarch64-apple-darwin machines)

tmccombs commented 6 months ago

Ah, yes running tests for an aarch64 executable on x86_64 won't work.

flaviomartins commented 6 months ago

Closed in https://github.com/conda-forge/fd-find-feedstock/pull/24#event-12772240584