sharkdp / fd

A simple, fast and user-friendly alternative to 'find'
Apache License 2.0
34.3k stars 816 forks source link

Fix #1085 for real #1549

Closed tavianator closed 6 months ago

tavianator commented 6 months ago

cross doesn't pass all environment variables through into the build container, so JEMALLOC_SYS_WITH_LG_PAGE=16 wasn't being picked up from the host. Instead, set it explicitly in Cross.toml.

Link: https://github.com/cross-rs/cross/wiki/Configuration

tavianator commented 6 months ago

@mathomp4 Do you mind testing the aarch64 artifacts from this PR, so we can see if we actually fixed it this time? https://github.com/sharkdp/fd/actions/runs/8971773406

mathomp4 commented 6 months ago

@mathomp4 Do you mind testing the aarch64 artifacts from this PR, so we can see if we actually fixed it this time? sharkdp/fd/actions/runs/8971773406

The answer is yes and no. For the GNU build it works:

$ /home/mthompso/fd-testing/fd-v10.0.0-aarch64-unknown-linux-gnu/fd -e lua --max-results 3
GitProjects/z.lua/
modulefiles/GCC12Env.lua
modulefiles/GCC13Env.lua

Huzzah!

But the MUSL build doesn't:

$ /home/mthompso/fd-testing/fd-v10.0.0-aarch64-unknown-linux-musl/fd -e lua --max-results 3
<jemalloc>: Unsupported system page size
<jemalloc>: Unsupported system page size
memory allocation of 5 bytes failed
Aborted (core dumped)
tavianator commented 6 months ago

@mathomp4 Well that's just because I forgot we even use jemalloc with musl. (We disable it for 32-bit musl builds, I forgot about the 32-bit part.)

Can you try https://github.com/sharkdp/fd/actions/runs/8972442583 once it finishes? Thanks again :)

mathomp4 commented 6 months ago

@mathomp4 Well that's just because I forgot we even use jemalloc with musl. (We disable it for 32-bit musl builds, I forgot about the 32-bit part.)

Can you try sharkdp/fd/actions/runs/8972442583 once it finishes? Thanks again :)

Things look good!

$ /home/mthompso/fd-testing/fd-v10.0.0-aarch64-unknown-linux-gnu/fd -e lua --max-results 3
modulefiles/GCC12Env.lua
modulefiles/GCC13Env.lua
modulefiles/cmake/3.29.2.lua
mthompso@gg1 ~
$ /home/mthompso/fd-testing/fd-v10.0.0-aarch64-unknown-linux-musl/fd -e lua --max-results 3
modulefiles/GCC12Env.lua
modulefiles/GCC13Env.lua
modulefiles/cmake/3.29.2.lua

thanks!