search

sharkdp / hexyl

A command-line hex viewer
Apache License 2.0
8.92k stars 227 forks source link

bin: offset should add to skip, not override it #119

Closed tommilligan closed 3 years ago

tommilligan commented 3 years ago

Closes #115

This PR aligns the behaviour of hexyl with xxd, when the --skip and --display-offset flags are both set.

Currently, --display-offset overrides --skip . In xxd, the two values are added together to produce the first address value.

Comparison of current hexyl and xxd behaviour.

sharkdp commented 3 years ago

Thank you very much!