search

sharkdp / hexyl

A command-line hex viewer
Apache License 2.0
8.92k stars 227 forks source link

Changed null char to `•` #169

Closed LemonjamesD closed 1 year ago

LemonjamesD commented 1 year ago

Kinda Resolves #166 This PR will changed the null char to • but it will not add the option to make it that or change it back to 0.

(For Hacktoberfest)

sharkdp commented 1 year ago

We already use a similar (the same?) Unicode code point for AsciiOther (see a few lines below your change), so that's not the best solution here, IMO.

LemonjamesD commented 1 year ago

I know that, could change it to . like other hex editors

sharkdp commented 1 year ago

If you look a few lines below your change, you could see that we already use • for AsciiOther. I looked around a bit and tried a few Unicode characters. So far, I like ⋄ best. It can be recognized as a 0 and it's not an ASCII character.

LemonjamesD commented 1 year ago

That would work, I'll see about changing it tonight if you're not gonna do it today

sharkdp commented 1 year ago

Solved in 7d38f70