search

sharkdp / hexyl

A command-line hex viewer
Apache License 2.0
8.92k stars 227 forks source link

`--no-characters` causes output artifacts when squeezing lines #171

Closed ravenexp closed 1 year ago

ravenexp commented 1 year ago

Sample output:

│000000d0│ 00 00 00 00 00 00 00 00 ┊ 00 00 00 00 00 00 00 00 │
│*       │                         ┊                         │        ┊        │
│000000f0│ 00 00 c8 43 00 80 54 44 ┊ 00 02 00 02 04 00 00 00 │

Note the extra ┊ │ on the right.

sharkdp commented 1 year ago

Thank you for reporting this.

FYI @mkatychev only if you are interested, of course.

mkatychev commented 1 year ago

Yeah I can take a look when I get some time this coming week.

@ravenexp does this happen with any data in ./tests/examples/? What's the full command you used and anything else that might help reproduce this.

ravenexp commented 1 year ago

@ravenexp does this happen with any data in ./tests/examples/? What's the full command you used and anything else that might help reproduce this.

Yes, the simplest way to reproduce is to run:

cargo run -- -C tests/examples/hello_world_elf64
mkatychev commented 1 year ago

@sharkdp https://github.com/sharkdp/hexyl/pull/174 is out in draft

Likely going to be merge conflicts with https://github.com/sharkdp/hexyl/pull/173 as well

sharkdp commented 1 year ago

I understand this is now closed via https://github.com/sharkdp/hexyl/pull/173 and https://github.com/sharkdp/hexyl/pull/177