search

sharkdp / hexyl

A command-line hex viewer
Apache License 2.0
8.92k stars 227 forks source link

Make --panels=auto the new default? #182

Closed sharkdp closed 1 year ago

sharkdp commented 1 year ago

The new --panels=auto option is really nice. Should we make it the new default (instead of --panels=2)?

If not (maybe because it is weird on very wide terminals), should we at least use --panels=1 automatically if the terminal width is too small to display the default two panels?

FYI @sharifhsn

sharifhsn commented 1 year ago

I think the second option makes more sense. It's expected behavior for hex viewers to print 16 bytes at a time, so deviating from that for the default would be unwise. But we can still make that calculation so that it doesn't wrap lines on the default 2 panels.

sharkdp commented 1 year ago

Agreed!

sharkdp commented 1 year ago

Implemented. This is actually pretty helpful when using --base=binary.