search

sharkdp / hexyl

A command-line hex viewer
Apache License 2.0
8.92k stars 227 forks source link

`/dev/zero` fix #204

Closed sharifhsn closed 6 months ago

sharifhsn commented 10 months ago

Fixes #200

sharkdp commented 6 months ago

Was this closed intentionally?

sharifhsn commented 6 months ago

No, I think when I rebased #194 it closed this PR. I would appreciate it if you could direct commit this change to master, as it's fairly trivial. Here's the commit: https://github.com/sharifhsn/hexyl/pull/2/commits/c189d60e1fc7a729983f3e23c4d5ae5eb9d97921

sharkdp commented 6 months ago

The change is trivial, but I wonder if there are any performance implications of flushing?

sharkdp commented 6 months ago

There is... unfortunately. 35% slower:

image