sharkdp / hexyl

A command-line hex viewer
Apache License 2.0
8.92k stars 227 forks source link

CI artifact names conflict #215

Closed FilipRazek closed 5 months ago

FilipRazek commented 5 months ago

In the current CI/CD setup, the artifacts generated by arm-unknown-linux-gnueabihf and arm-unknown-linux-musleabihf have the same name, hexyl_0.14.0_armhf.deb. The default behavior from upload-artifact seems to be to fail in this case (which was probably a breaking change in v4).

This can be seen on this PR where no meaningful change was made (running against the latest version on my fork): PR 1

However, the CI/CD currently depends on upload-artifact@master, which is not the latest branch (main is).

I do not understand why the CI breaks now, but it would make sense to:

sharkdp commented 5 months ago

Yes. Thank you. I did similar changes in my other projects (although I didn't notice the branch name change…)

FilipRazek commented 5 months ago

Great, thanks!