Configure Gitpod and add contributing instructions to README.md

sharkdp / hexyl

A command-line hex viewer

Apache License 2.0

8.93k stars 227 forks source link

Configure Gitpod and add contributing instructions to README.md #28

Closed jankeromnes closed 5 years ago

jankeromnes commented 5 years ago

Hello, thanks a lot for developing hexyl!

I took the liberty of configuring Gitpod (an online development environment) for hexyl development, and it seems to work like a charm 🎉:

You can give it a try first by clicking here:

I've also added some contribution tips in README.md. Please let me know what you think.

sharkdp commented 5 years ago

Thank you for your contribution. Gitpod looks like a very cool tool, but I'd rather not add any workflow/IDE/editor-specific files to my repositories.

Given that you seem to be associated with the company behind Gitpod (correct me if I'm wrong), I can not help but see this as a way to use this open source project as a platform for advertisement. It would be good if you explicitly mention your affiliation with TypeFox in future Gitpod-related PRs.

jankeromnes commented 5 years ago

Hi @sharkdp, thank you for your honest reply, and I apologize if this contribution wasn't appropriate. I am indeed affiliated with TypeFox, and I generally try to mention it in Gitpod-related pull requests -- sorry that I didn't here.

It's true that supporting hexyl would give our tool some visibility, but given that Gitpod is free for open source, and that it works quite well to let anyone build and run hexyl in seconds, I thought I'd mention it here. However it's also fair to let users figure out their own tools and workflows. Thanks again for your time, and sorry for the disruption!

sharkdp commented 5 years ago

Thank you.