search

sharkdp / hexyl

A command-line hex viewer
Apache License 2.0
8.93k stars 227 forks source link

Pale cyan on white background #34

Closed vi closed 5 years ago

vi commented 5 years ago

screenshot

In gnome-terminal or in xterm or in lxterminal.

Only looks properly in Linux text console (probably because of it has dark background).

kilobyte commented 5 years ago

There's no reliable way to detect background colors. Most people use on-black, but indeed some terminals ship with a heretical default.

I keep arguing that the palette of 16 standard colors should be kept readable by the terminal (by having appropriate contrast in the preloads), but both 24-bit and 256-color schemes explicitly provide absolute RGB color values. No idea how to deal with that apart from a setting the user needs to change.

vi commented 5 years ago

If Hexyl is intended to be used only on dark background, then force black background for all Hexyl output.

kilobyte commented 5 years ago

I tried forcing dark background in a program of mine once, and people complained. Turns out the wrong-thinkers who insist on a white background are adamant in their heresy...

sharkdp commented 5 years ago

No, I also think forcing a background color would be a bad decision. It would probably also not look great. I'd say we should probably move forward with #18, which would also solve this issue here (if users have a decent base color scheme).

vi commented 5 years ago

Maybe hexyl needs overridable/configurable colour schemes (including grayscale)?

kilobyte commented 5 years ago

Perhaps; but any extra customization risks becoming bloat.

sharkdp commented 5 years ago

closed via #38.

sharkdp commented 5 years ago

Fixed in v0.4.0.