search

sharkdp / hexyl

A command-line hex viewer
Apache License 2.0
8.92k stars 227 forks source link

snap support #86

Closed purveshpatel511 closed 4 years ago

purveshpatel511 commented 4 years ago

A candidate/stable release snap is created for cross platform installation among various Linux distros, including CentOS, KDE Neon, openSUSE, Red Hat and many more.

snap is already live on : https://snapcraft.io/hexyl

you can check out that.

bjorn3 commented 4 years ago

You should probably not commit the snap, but instead setup CI to build it.

sharkdp commented 4 years ago

Thank you very much for your contribution!

As @bjorn3 stated, we don't really want to add a binary snap file to this repository. Also, as I am not maintaining the snap file myself (and not planning to), I would prefer if distribution-specific files would be hosted somewhere else (e.g. in a separate repository).

I didn't really understand why you would like to add additional testdata files?

What we can definitely do is to add installation instructions for snap to the README.

purveshpatel511 commented 4 years ago

@sharkdp , thanks for check out my pull request. I understand your concern and i am very happy to host a separate repository for snap distribution of this repo.

sharkdp commented 4 years ago

@purvesh-linux11 Thank you!

I'm going to close this PR. Happy to include the README changes at some point.