Closed sharkdp closed 4 years ago
this has actually already been brought up by @ErichDonGubler here: https://github.com/sharkdp/hexyl/issues/44#issuecomment-634105599
If you want to assign this to me, I'm more than happy to take it. anyhow
is an easy way to add some simple error handling, and this should be fast. :)
If you want to assign this to me, I'm more than happy to take it
:+1:
How's this issue looking? I believe we handled the missing error diagnostics for parse failures here.
Absolutely. Forgot to close it. Thanks!
We should print an error if the parsing of the size argument for
--length
,--skip
, … fails. Currently, we silently ignore the argument:I'd prefer if we use
anyhow
for error handling (if we want to rely on a library at all).If we want to have good error messages, we probably want to modify
to return a
Result<PositiveI64>
with several possible error paths.